NetPlay: Limit nickname length #7410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techjar
force-pushed
the
netplay-max-name-length
branch
from
cd827c2
to
cbc7928
Compare
|
Is the limit in this PR actually 30 characters, or is it 30 bytes (when encoded as UTF-8)? The latter might be a bit restrictive for e.g. Japanese, since it would mean you only can use 10 characters. |
|
It's based on whatever |
|
Then it's 30 bytes. |
Techjar
force-pushed
the
netplay-max-name-length
branch
from
cbc7928
to
9d9c9de
Compare
lioncash
reviewed
Sep 12, 2018
Source/Core/Core/NetPlayProto.h
Outdated
| @@ -164,6 +165,7 @@ enum | |||
|
|
|||
| constexpr u32 NETPLAY_LZO_IN_LEN = 1024 * 64; | |||
| constexpr u32 NETPLAY_LZO_OUT_LEN = NETPLAY_LZO_IN_LEN + (NETPLAY_LZO_IN_LEN / 16) + 64 + 3; | |||
| const unsigned int MAX_NAME_LENGTH = 30; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Source/Core/Core/NetPlayServer.cpp
Outdated
| delete (PlayerId*)netEvent.peer->data; | ||
| netEvent.peer->data = nullptr; | ||
| sf::Packet spac; | ||
| spac << (MessageId)error; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Source/Core/Core/NetPlayServer.cpp
Outdated
| Send(netEvent.peer, spac); | ||
| if (netEvent.peer->data) | ||
| { | ||
| delete (PlayerId*)netEvent.peer->data; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Source/Core/Core/NetPlayServer.cpp
Outdated
| } | ||
| else | ||
| { | ||
| auto it = m_players.find(*(PlayerId*)netEvent.peer->data); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Techjar
changed the title
Techjar
force-pushed
the
netplay-max-name-length
branch
from
9d9c9de
to
f2c53fb
Compare
Techjar
changed the title
JosJuice
reviewed
Sep 12, 2018
Source/Core/Common/StringUtil.cpp
Outdated
| @@ -449,6 +449,12 @@ void StringPopBackIf(std::string* s, char c) | |||
| s->pop_back(); | |||
| } | |||
|
|
|||
| size_t StringUTF8Size(const std::string& str) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Techjar
force-pushed
the
netplay-max-name-length
branch
from
f2c53fb
to
fc35bbd
Compare
Techjar
force-pushed
the
netplay-max-name-length
branch
3 times, most recently
from
857d52a
to
9a42b03
Compare
Techjar
changed the title
Techjar
force-pushed
the
netplay-max-name-length
branch
from
9a42b03
to
2def4d4
Compare
delroth
reviewed
Nov 22, 2018
Techjar
force-pushed
the
netplay-max-name-length
branch
from
2def4d4
to
9a42b03
Compare
Techjar
changed the title
Techjar
force-pushed
the
netplay-max-name-length
branch
from
9a42b03
to
92a95ec
Compare
Techjar
force-pushed
the
netplay-max-name-length
branch
from
92a95ec
to
18fc714
Compare
Techjar
changed the title
Techjar
force-pushed
the
netplay-max-name-length
branch
from
18fc714
to
dbf9c14
Compare
Techjar
force-pushed
the
netplay-max-name-length
branch
from
dbf9c14
to
9b07d1c
Compare
jordan-woyak
approved these changes
Jul 16, 2020
Techjar
force-pushed
the
netplay-max-name-length
branch
from
9b07d1c
to
68e6f08
Compare
Ridiculously long nicknames cause UI silliness, so 30 characters seems like a reasonable limit, as it's the same as the forum.
Techjar
force-pushed
the
netplay-max-name-length
branch
from
68e6f08
to
037aa21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
32767 character names is more than a bit silly, so I figured adding a (server enforced) length limit would be a good idea. 30 characters seems like a reasonable limit, as it's the same as the forums.