New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where breakpoint type wasn't correct in debugger memory view. #7438

Merged
merged 1 commit into from Oct 12, 2018

Conversation

3 participants
@RolandMunsil
Contributor

RolandMunsil commented Sep 28, 2018

If you right click on a cell in the memory view (MemoryViewWidget) you can set a breakpoint at that cell. The type of breakpoint to be set wasn't being loaded into MemoryViewWidget from the user's settings file. It was being loaded into MemoryWidget, though, so to fix this I made it so when MemoryWidget loads the breakpoint settings it also sets the MemoryViewWidget's breakpoint type.

@RolandMunsil

This comment has been minimized.

Show comment
Hide comment
@RolandMunsil

RolandMunsil Sep 29, 2018

Contributor

No idea why the android build is failing - I only modified the Qt classes so I assume it shouldn't affect android? Plus the error message given doesn't seem to be related at all to my changes.

Contributor

RolandMunsil commented Sep 29, 2018

No idea why the android build is failing - I only modified the Qt classes so I assume it shouldn't affect android? Plus the error message given doesn't seem to be related at all to my changes.

@BhaaLseN

This comment has been minimized.

Show comment
Hide comment
@BhaaLseN

BhaaLseN Sep 29, 2018

Member

You can ignore that one for now, thats an infrastructure issue on our end.

Member

BhaaLseN commented Sep 29, 2018

You can ignore that one for now, thats an infrastructure issue on our end.

@RolandMunsil

This comment has been minimized.

Show comment
Hide comment
@RolandMunsil

RolandMunsil Oct 12, 2018

Contributor

Is there something else I need to do? Or does it just usually take some time to get through all the PRs?

Contributor

RolandMunsil commented Oct 12, 2018

Is there something else I need to do? Or does it just usually take some time to get through all the PRs?

@BhaaLseN

This comment has been minimized.

Show comment
Hide comment
@BhaaLseN

BhaaLseN Oct 12, 2018

Member

It simply takes time for the right people to go thru and comment on PRs. You'll have to be a little more patient, but given the kind of change it shouldn't take too long to merge once it was reviewed.

Member

BhaaLseN commented Oct 12, 2018

It simply takes time for the right people to go thru and comment on PRs. You'll have to be a little more patient, but given the kind of change it shouldn't take too long to merge once it was reviewed.

@lioncash lioncash merged commit 57529bc into dolphin-emu:master Oct 12, 2018

9 of 10 checks passed

pr-android Build failed on builder pr-android
Details
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment