Android: Add controller rumble support #7443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahdihijazi
suggested changes
Oct 26, 2018
| if (vibrator != null && vibrator.hasVibrator()) | ||
| { | ||
| setting.setValue(device.getName()); | ||
| editor.putString(setting.getKey(), String.valueOf(device.getName())); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| { | ||
| setting.setValue(device.getName()); | ||
| editor.putString(setting.getKey(), String.valueOf(device.getName())); | ||
| editor.putString(setting.getKey() + "desc", String.valueOf(device.getDescriptor())); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -49,7 +53,11 @@ public boolean onKeyEvent(int keyCode, KeyEvent event) | |||
| case KeyEvent.ACTION_UP: | |||
| if (!ControllerMappingHelper.shouldKeyBeIgnored(event.getDevice(), keyCode)) | |||
| { | |||
| saveKeyInput(event); | |||
| // Special case for Rumble | |||
| if (setting.getKey().contains(SettingsFile.KEY_EMU_RUMBLE)) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Android can be funky with controller vibration. Of the three controlers I have that contain a vibrator(PS3, Xbox360, 2017 Shield controller), only the Xbox360 controller registered as having a vibrator. So YYMV depending on the driver support of the device.
zackhow
force-pushed
the
device-rumble
branch
from
d42c0f3
to
3499a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Android can be funky with controller vibration. Of the three controlers I have that contain a
vibrator(PS3, Xbox360, 2017 Shield controller), only the Xbox360 controller registered as having
a vibrator. So YYMV depending on the driver support of the device.