New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGL: Disable scissor test when calling glBlitFramebuffer() #7451

Merged
merged 1 commit into from Oct 11, 2018

Conversation

3 participants
@stenzek
Contributor

stenzek commented Oct 3, 2018

glBlitFramebuffer() does not bypass the scissor test, which meant that parts of texture copies (e.g. XFB) could have been clipped when running under OpenGL ES, as glCopyImageSubData() is not supported.

The other call sites for glBlitFramebuffer() are behind ResetAPIState() calls, so they are unaffected. We really need better state tracking in the GL backend.. one day..

@Tilka

This comment has been minimized.

Show comment
Hide comment
@Tilka

Tilka Oct 9, 2018

Member

Please rebase so fifoci can compare with master.

Member

Tilka commented Oct 9, 2018

Please rebase so fifoci can compare with master.

OGL: Disable scissor test when calling glBlitFramebuffer()
glBlitFramebuffer() does not bypass the scissor test, which meant that
part of texture copies (e.g. XFB) could have been clipped when running
under OpenGL ES, as glCopyImageSubData() is not supported.
@stenzek

This comment has been minimized.

Show comment
Hide comment
@stenzek

stenzek Oct 9, 2018

Contributor

Done. I suspect it won't make a difference for fifoci, as it'd be going through the CopySubImage path, but for the record I did test this in both GL (with and without CopySubImage), and GLES.

Contributor

stenzek commented Oct 9, 2018

Done. I suspect it won't make a difference for fifoci, as it'd be going through the CopySubImage path, but for the record I did test this in both GL (with and without CopySubImage), and GLES.

@Tilka Tilka merged commit b35e0fd into dolphin-emu:master Oct 11, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment