New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evdev: simplify code #7461

Merged
merged 1 commit into from Oct 8, 2018

Conversation

2 participants
@Tilka
Member

Tilka commented Oct 6, 2018

No need to check write access if we call open() right after which checks that anyway. Also only get the device name once.

@stenzek

stenzek approved these changes Oct 8, 2018

Haven't used libevdev, but the logic here seems okay.

evdev: simplify code
No need to check write access if we call open() right after which checks
that anyway. Also only get the device name once.

@Tilka Tilka merged commit 7551e3d into dolphin-emu:master Oct 8, 2018

9 of 10 checks passed

pr-android Auto build in progress on builder pr-android
Details
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@Tilka Tilka deleted the Tilka:evdev branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment