New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Require user to enable savestate menu options #7466

Merged
merged 1 commit into from Oct 12, 2018

Conversation

4 participants
@zackhow
Member

zackhow commented Oct 7, 2018

With the nature of android updates invalidating save states, it's best to hide these options unless enabled by the user. The option to use savestates can now be enabled via the General settings menu.

@JMC47 @MayImilae @JosJuice Let me know if the warning can be improved. Possibly also something like "disable updating in the play store if you plan to use savestates as the primary way of saving."

savestates

Android: Require user to enable savestate menus
With the nature of android updates invalidating save states, it's best to hide
these options unless enabled by the user. The option to use savestates can now
be enabled via the General settings menu.
@Helios747

This comment has been minimized.

Show comment
Hide comment
@Helios747

Helios747 Oct 7, 2018

Contributor

Absolutely a +1 for me.

With auto updating being a default thing for play store users, we really need to protect them from themselves and our very opaque save state system.

It's fine to use, but they should definitely be aware that updating will break it, and if they still insist on using at as their primary saves, they can just go disable auto updates in the play store.

Contributor

Helios747 commented Oct 7, 2018

Absolutely a +1 for me.

With auto updating being a default thing for play store users, we really need to protect them from themselves and our very opaque save state system.

It's fine to use, but they should definitely be aware that updating will break it, and if they still insist on using at as their primary saves, they can just go disable auto updates in the play store.

@JosJuice

This comment has been minimized.

Show comment
Hide comment
@JosJuice

JosJuice Oct 7, 2018

Contributor

+1 for me too. But please don't add a note about disabling auto updates if you want to use savestates as the primary way of saving, because savestates are problematic enough that you should never use them as the primary way of saving even if it wasn't for the problem of updates.

Contributor

JosJuice commented Oct 7, 2018

+1 for me too. But please don't add a note about disabling auto updates if you want to use savestates as the primary way of saving, because savestates are problematic enough that you should never use them as the primary way of saving even if it wasn't for the problem of updates.

@lioncash lioncash merged commit 7ac90b5 into dolphin-emu:master Oct 12, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment