New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FifoPlayer: reduce XF_REGS_SIZE to what we know #7470

Merged
merged 1 commit into from Oct 9, 2018

Conversation

2 participants
@Tilka
Member

Tilka commented Oct 8, 2018

This avoids out-of-bounds warnings when replaying FIFO captures.

The value of XF_REGS_SIZE is written into the DFF header and we only read the min of XF_REGS_SIZE and the header value, so this change is backward compatible and doesn't break forward compatibility for old Dolphin versions either.

FifoPlayer: reduce XF_REGS_SIZE to what we know
This avoids out-of-bounds warnings when replaying FIFO captures.

The value of XF_REGS_SIZE is written into the DFF header and we only
read the min of XF_REGS_SIZE and the header value, so this change is
backward compatible and doesn't break forward compatibility for old
Dolphin versions either.
@JMC47

This comment has been minimized.

Show comment
Hide comment
@JMC47

JMC47 Oct 9, 2018

Contributor

My fifologs seem to work with this.

Contributor

JMC47 commented Oct 9, 2018

My fifologs seem to work with this.

@Tilka Tilka merged commit 5b8e1e6 into dolphin-emu:master Oct 9, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@Tilka Tilka deleted the Tilka:fifoplayer branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment