Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gecko sorting back to manual #7480

Merged
merged 1 commit into from Oct 14, 2018
Merged

Conversation

EternalllZM
Copy link
Contributor

@EternalllZM EternalllZM commented Oct 9, 2018

Gecko codes are a core foundation of most netplay sessions and most general modding cases. It has gone so far as to now have an ini for almost every game.

After the massive UI overhaul, the gecko code sorting defaults to Alphabetical with no option to change it. This removes the possibility for netplay games to have important and necessary codes at the top for easy selecting, and removes the ability to sort massive code lists in categories.

This will also make the sorting consistent with AR codes, which are sorted manually as of the latest commit.

Gecko codes are a core foundation of most netplay sessions and most general modding cases. It has gone so far as to now have an ini for almost every game.

After the massive UI overhaul, the gecko code sorting defaults to Alphabetical with no option to change it. This removes the possibility for netplay builds to have important and necessary codes at the top for easy selecting, and removes the ability to sort massive code lists in categories.

This will also make the sorting consistent with AR codes, which are sorted manually.
@ghost
Copy link

ghost commented Oct 9, 2018

You don't need to close and open a new one, you can update the old pull request with a forced push.

At least in git bash, you'd go git push yourgithubrepo branchname --force

Even if you screwd up the commits, apparently, and you make another branch then you go git push yourgithubrepo fixedbranchname:oldbranchname --force

@Tilka Tilka merged commit 1abb279 into dolphin-emu:master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants