New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning and zero-initialize variables #7482

Merged
merged 2 commits into from Oct 9, 2018

Conversation

3 participants
@Tilka
Member

Tilka commented Oct 9, 2018

cpu_core is an enum class.

If the register view is active before starting a game, it will read uninitialized memory.

@Tilka Tilka merged commit f8c679b into dolphin-emu:master Oct 9, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@Tilka Tilka deleted the Tilka:sanity branch Oct 9, 2018

@lioncash

This comment has been minimized.

Show comment
Hide comment
@lioncash

lioncash Oct 10, 2018

Member

fwiw, PowerPCState would always be zero-initialized on program start even w/o the {} initializer on it, since it has static storage duration.

Member

lioncash commented Oct 10, 2018

fwiw, PowerPCState would always be zero-initialized on program start even w/o the {} initializer on it, since it has static storage duration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment