Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat Wii Menu 1.0 as NTSC-U #7487

Merged
merged 1 commit into from Oct 12, 2018
Merged

Treat Wii Menu 1.0 as NTSC-U #7487

merged 1 commit into from Oct 12, 2018

Conversation

JosJuice
Copy link
Member

See the comments of PR #7440.

BhaaLseN
BhaaLseN approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot really test this since 1.0 isn't on NUS, but this looks a lot better than the special casing.

@lioncash lioncash merged commit bbb08ee into dolphin-emu:master Oct 12, 2018
@JosJuice JosJuice deleted the wii-menu-1.0-region-2 branch October 12, 2018 19:00
@AdmiralCurtiss
Copy link
Contributor

If 1.0 is USA-only, shouldn't we remove that special case in GetSysMenuVersionString() too and return a more consistent 1.0U?

JosJuice added a commit to JosJuice/dolphin that referenced this pull request Oct 14, 2018
@JosJuice
Show 1.0U instead of 1.0 for Wii Menu 1.0
34c05e1 
As suggested by dolphin-emu#7487 (comment)
@JosJuice JosJuice mentioned this pull request Oct 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@BhaaLseN BhaaLseN BhaaLseN approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@JosJuice @AdmiralCurtiss @lioncash @BhaaLseN