Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT64: correctly sign-extend immediate RC values #751

Merged
merged 1 commit into from Aug 7, 2014

Conversation

FioraAeterna
Copy link
Contributor

No description provided.

@delroth
Copy link
Member

delroth commented Aug 6, 2014

How does that relate to #747?

@FioraAeterna
Copy link
Contributor Author

... oops. I didn't realize it was the exact same bug.

@FioraAeterna
Copy link
Contributor Author

I am a huge doof-face.

@FioraAeterna
Copy link
Contributor Author

Re-opening on Delroth's request; he apparently prefers my solution, so I merged the rest of his patch into mine.

@FioraAeterna FioraAeterna reopened this Aug 6, 2014
@JMC47
Copy link
Contributor

JMC47 commented Aug 6, 2014

Looks good to me. It should fix the hangs mentioned in issue 7538 plus 1080 Avalanche for the GC.

@Sonicadvance1
Copy link
Contributor

Yes.

Sonicadvance1 added a commit that referenced this pull request Aug 7, 2014
JIT64: correctly sign-extend immediate RC values
@Sonicadvance1 Sonicadvance1 merged commit 88934fd into dolphin-emu:master Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants