Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11Utils: Remove unneeded SendButtonEvent / SendKeyEvent utilities #752

Merged
merged 1 commit into from Aug 6, 2014

Conversation

magcius
Copy link
Member

@magcius magcius commented Aug 6, 2014

This was used to send fake button or key events to every backend to
implement freelook. When I ported these to be based on wx events in
commit 5248211, I didn't realize that these were now unused, so I didn't
remove them. Do that now.

This was used to send fake button or key events to every backend to
implement freelook. When I ported these to be based on wx events in
commit 5248211, I didn't realize that these were now unused, so I didn't
remove them. Do that now.
@delroth
Copy link
Member

delroth commented Aug 6, 2014

How does that work with freelook on nogui?

@magcius
Copy link
Member Author

magcius commented Aug 6, 2014

It doesn't. Nobody ever wrote the code to support freelook on NoGUI.

@delroth
Copy link
Member

delroth commented Aug 6, 2014

I thought that was the whole point of that code you're removing?

@magcius
Copy link
Member Author

magcius commented Aug 6, 2014

I don't see how that has anything to do with it, given that these helpers are being called from Frame.cpp, which isn't built in nogui mode.

And even if somebody wrote the code to make it work on nogui, it wouldn't need these helpers anyway, since the events would come from the native window system, not from a wx event loop that isn't running.

@delroth
Copy link
Member

delroth commented Aug 6, 2014

I see. Thanks for clarifying this.

@lioncash
Copy link
Member

lioncash commented Aug 6, 2014

Looks good to me

lioncash added a commit that referenced this pull request Aug 6, 2014
X11Utils: Remove unneeded SendButtonEvent / SendKeyEvent utilities
@lioncash lioncash merged commit 470bfc9 into dolphin-emu:master Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants