New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supportedOS manifests for Windows 7, 8, 8.1, and 10 to DolphinQt … #7544

Merged
merged 1 commit into from Nov 7, 2018

Conversation

3 participants
@DXGLdotinfo
Contributor

DXGLdotinfo commented Nov 4, 2018

…and Updater. Enables high contrast themes on Windows 8+.

Add supportedOS manifests for Windows 7, 8, 8.1, and 10 to DolphinQt …
…and Updater. Enables high contrast themes on Windows 8+.
@DXGLdotinfo

This comment has been minimized.

Contributor

DXGLdotinfo commented Nov 4, 2018

I have found an issue with this change - if Dolphin is started while in High Contrast it causes the audio sliders to become narrow. As such, I will be closing this Pull Request.

@DXGLdotinfo DXGLdotinfo closed this Nov 4, 2018

@BhaaLseN

This comment has been minimized.

Member

BhaaLseN commented Nov 4, 2018

Pretty sure sliders are handled in #7528

@DXGLdotinfo

This comment has been minimized.

Contributor

DXGLdotinfo commented Nov 4, 2018

Then in that case I will be reopening it, allowing #7528 to take care of the Qt GUI aspects of which I have no experience.

@DXGLdotinfo

This comment has been minimized.

Contributor

DXGLdotinfo commented Nov 4, 2018

Weird, thought I clicked reopen.

@DXGLdotinfo DXGLdotinfo reopened this Nov 4, 2018

@delroth delroth merged commit a778824 into dolphin-emu:master Nov 7, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment