New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Cache game list in user path #7560

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@weihuoya
Contributor

weihuoya commented Nov 10, 2018

game list file will be removed when app uninstalled.
so save game list in user path.

@JosJuice

This comment has been minimized.

Contributor

JosJuice commented Nov 10, 2018

If you want the game list cache to be in the dolphin-emu folder on the SD card, you can just use new GameFileCache() instead of providing a path as an argument.

But I don't think I fully understand this change. Isn't the list of game directories still going to be deleted when the user uninstalls the app, making Dolphin ignore the data in the game list cache once Dolphin has scanned through the list of game directories?

@weihuoya weihuoya force-pushed the weihuoya:gamelist-cache branch from e03e97a to e9669d5 Nov 10, 2018

@weihuoya

This comment has been minimized.

Contributor

weihuoya commented Nov 10, 2018

sorry, I miss something.
can't use new GameFileCache(), native method need an argument to specify file path.

@JosJuice

This comment has been minimized.

Contributor

JosJuice commented Nov 10, 2018

Ah, you're right, the GameFileCache() constructor that exists in C++ is not exposed in the Java interface. But it shouldn't be too hard to add it to the Java interface.

I don't like that the list of game directories now is stored in the game list cache, though. It's supposed to just be a cache, not something that holds user settings. If you want the list of game directories to be stored in the dolphin-emu folder, you should instead replace the usage of getDefaultSharedPreferences with something that writes to and reads from a file in dolphin-emu/Config/.

@weihuoya weihuoya force-pushed the weihuoya:gamelist-cache branch from e9669d5 to cb7152e Nov 11, 2018

@weihuoya weihuoya force-pushed the weihuoya:gamelist-cache branch from cb7152e to b6f3747 Nov 11, 2018

@weihuoya

This comment has been minimized.

Contributor

weihuoya commented Nov 11, 2018

yes, I find there a ISOPath setting in config file, and setting ui to manage it on PC.
I think it's not necessary to add a setting ui on Android, just refresh library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment