New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Enable sustained performance mode on Android #7568

Open
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@JonnyH
Contributor

JonnyH commented Nov 12, 2018

Is this useful? Should we add it to a UI option?

@Techjar

This comment has been minimized.

Contributor

Techjar commented Nov 12, 2018

Devices don't necessarily handle this in a beneficial way, so it should definitely be an option. As for whether its useful, I would say yes as long as we can find some devices which show an improvement with it on.

@zackhow

This comment has been minimized.

Member

zackhow commented Nov 12, 2018

The way I understand this is it brings a consistent experience over the course of the activity, that it will drop performance in the short term to prevent slowdowns later due to heating. So instead of 60 fps for 15 minutes -> 30 fps after, you get 45fps for 60 minutes. Either way, most(all?) android phones have trouble even hitting 60fps sustained, so I don't think this is even an option atm. Maybe in two(five...?) years

Looking at the documentation, I'd say we'd want something closer to 'Exclusive core'
https://source.android.com/devices/tech/power/performance#exclusive_core

@Techjar

This comment has been minimized.

Contributor

Techjar commented Nov 12, 2018

@zackhow Doesn't look like that does anything to the CPU governor, and is just a higher level construct for CPU pinning to prevent other threads preempting yours. Not very useful to us, as our problem is aggressive CPU scaling causing stutters.

@Helios747

This comment has been minimized.

Contributor

Helios747 commented Nov 16, 2018

It certainly wouldn't hurt. Default it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment