New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debugger] Display memory tab contents while game is running #7576

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@UnclePunch
Contributor

UnclePunch commented Nov 16, 2018

Changes the condition to not display memory values when the core is !running && !paused, rather than just !paused. This caused the memory to never be updated while the game is running.

Display memory while game is running
Changes the condition to not display memory values when the core is !running && !paused, rather than just !paused. This caused the memory to never be updated while the game is running.

@UnclePunch UnclePunch changed the title from Display memory tab contents while game is running to [Debugger] Display memory tab contents while game is running Nov 16, 2018

@@ -101,7 +101,8 @@ void MemoryViewWidget::Update()
if (addr == m_address)
addr_item->setSelected(true);
if (Core::GetState() != Core::State::Paused || !PowerPC::HostIsRAMAddress(addr))
if (Core::GetState() != Core::State::Paused && Core::GetState() != Core::State::Running ||

This comment has been minimized.

@leoetlino

leoetlino Nov 17, 2018

Member

Parentheses please. Otherwise it's not immediately obvious what this does.

@shuffle2

This comment has been minimized.

Contributor

shuffle2 commented Nov 17, 2018

Does this actually work well? I think it was done for speed...

@UnclePunch

This comment has been minimized.

Contributor

UnclePunch commented Nov 17, 2018

Does this actually work well? I think it was done for speed...

Yeah I don't see why this would hurt performance. It updates when interacted with, not every game frame. It seemed like it was meant to display null values when no game was running, instead of when not paused. In addition, the debugger in wx would show memory regardless of it were paused or running.

@shuffle2

This comment has been minimized.

Contributor

shuffle2 commented Nov 23, 2018

ok, i'll take your word for it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment