Jit64: some load/store optimizations #758
Conversation
| } | ||
| else | ||
| { | ||
| if (gpr.R(a).IsSimpleReg() && gpr.R(b).IsSimpleReg()) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
FioraAeterna
force-pushed
the
loadstoreopt
branch
2 times, most recently
from
704a562
to
5425ad9
Compare
| } | ||
| // In this case we need an extra temporary register. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@FioraAeterna: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. Kind of worried that one of the constant paths might be broken... but LGTM. @dolphin-emu-bot allowmerge |
FioraAeterna
force-pushed
the
loadstoreopt
branch
2 times, most recently
from
a59541f
to
649a6ee
Compare
Avoid extra ops during address calculation in loads; use LEAs or immediates whenever possible.
FioraAeterna
force-pushed
the
loadstoreopt
branch
from
649a6ee
to
0432564
Compare
Jit64: some load/store optimizations
|
This build broke F-Zero GX. |
|
Yeah, it looks like it broke some games, and I put in #899 to fix it, but people seem to disagree on whether that's the correct solution, or if we need to enable MMU Hack for those games. I mean, I rather dislike the build being broken, but I can't make them commit a solution xD |
Avoid extra ops during address calculation in loads; use LEAs or immediates whenever possible.