New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/ControllersWindow: Fix Wiimote settings not being re-enabled after quitting NetPlay #7588

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@Techjar
Contributor

Techjar commented Nov 23, 2018

We no longer allow accessing controller config while NetPlay is running, so this check is no longer needed.

@@ -373,7 +373,7 @@ void ControllersWindow::OnWiimoteRefreshPressed()
void ControllersWindow::OnEmulationStateChanged(bool running)
{
if (!SConfig::GetInstance().bWii || NetPlay::IsNetPlayRunning())

This comment has been minimized.

@leoetlino

leoetlino Dec 5, 2018

Member

Not sure I understand what this does... So if the user starts a GameCube game then starts a Wii game, the options won't be enabled?

This comment has been minimized.

@Techjar

Techjar Dec 5, 2018

Contributor

I'm actually going to refactor this PR, as this NetPlay check doesn't need to exist anymore since the controllers dialog is disabled while NetPlay is running.

Qt/ControllersWindow: Fix Wiimote settings not being re-enabled after…
… quitting NetPlay

We no longer allow accessing controller config while NetPlay is
running, so this check is no longer needed.

@Techjar Techjar force-pushed the Techjar:controller-dialog-wiimote-disabled-bug branch from 39068c1 to a2545a1 Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment