Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement resource packs #7600
UI design review:
- I feel like there should be some way to describe what game(s) the pack is supposed to apply to. Whether that's autodetected (collect list of game IDs, xref against your library) or manual (field in the JSON specifying the game title) is up to you.
- Is there a way to read the full pack name / description, no truncation, without opening the zip file? The current table-based UI seems inadequate to do that.
While a detail pop-up is probably a pain to implement (another dialog box!) it may be the best way to do that.
- I don't see any way to actually open the website link in your browser. Consider a double-click action, or if something prevents that, change it to a
Copy Link(to clipboard) button without showing the website in the dialog (people can inspect it when they paste).
As always, these are suggestions, feel free to push back against any of them.
This adds more complexity to an already large PR, so I'm gonna say no to that one.
Fixed. I think it's sufficient for now.
Links can be opened now by double clicking on them