New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using g_jit outside of JitInterface #7602

Open
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@CrystalGamma

CrystalGamma commented Dec 2, 2018

Replace g_jit in x86-64 ASM routines code by m_jit member reference.
Followup on #7599.

@Tilka

Tilka approved these changes Dec 12, 2018

@CrystalGamma

OK, I guess there's nothing wrong with marking those constructors as explicit (I didn't even know about that feature … how long has it been in the language?).
I hope there are no objections on a more general level?

Show resolved Hide resolved Source/Core/Core/PowerPC/Jit64Common/EmuCodeBlock.h Outdated
Show resolved Hide resolved Source/Core/Core/PowerPC/Jit64Common/Jit64AsmCommon.h Outdated
Show resolved Hide resolved Source/Core/Core/PowerPC/Jit64Common/Jit64AsmCommon.h Outdated
Show resolved Hide resolved Source/Core/Core/PowerPC/Jit64Common/Jit64Base.h Outdated
Show resolved Hide resolved Source/Core/Core/PowerPC/Jit64Common/Jit64Base.h Outdated
Show resolved Hide resolved Source/Core/Core/PowerPC/Jit64Common/TrampolineCache.h Outdated
@lioncash

This comment has been minimized.

Member

lioncash commented Dec 15, 2018

(I didn't even know about that feature … how long has it been in the language?).

Since C++98

I hope there are no objections on a more general level?

Nope

@CrystalGamma

This comment has been minimized.

CrystalGamma commented Dec 15, 2018

Hmm, before looking at Dolphin I only ever looked at pre-standard versions of C++, specifically MSVC6 … shows how much I know :S

@CrystalGamma CrystalGamma force-pushed the CrystalGamma:stop-g_jit branch from b3ddf05 to ed731ad Dec 15, 2018

CrystalGamma
stop using g_jit outside of JitInterface
Replace g_jit in x86-64 ASM routines code by m_jit member reference

@CrystalGamma CrystalGamma force-pushed the CrystalGamma:stop-g_jit branch from ed731ad to 2f490e4 Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment