New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: fx index buffer reserve size #7604

Merged
merged 1 commit into from Dec 3, 2018

Conversation

3 participants
@weihuoya
Contributor

weihuoya commented Dec 3, 2018

opengl index buffer reserve size is right.
but vulkan miss this.
2 bytes per index.

@JMC47

This comment has been minimized.

Contributor

JMC47 commented Dec 3, 2018

@JMC47

This comment has been minimized.

Contributor

JMC47 commented Dec 3, 2018

Does this fix any noticeable issues? Curious so I can test it.

@weihuoya

This comment has been minimized.

Contributor

weihuoya commented Dec 3, 2018

Resident evil 4 will crash at chapter 1-3, my owned build.

@weihuoya weihuoya force-pushed the weihuoya:vulkan-index-buffer branch from 2435a9d to 3ab0f02 Dec 3, 2018

@stenzek

stenzek approved these changes Dec 3, 2018

LGTM. Note that the underlying buffer sizes here all differ between the backends, something I would like to rectify in the future by moving the logic to common.

@stenzek stenzek merged commit c675ef1 into dolphin-emu:master Dec 3, 2018

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@weihuoya weihuoya deleted the weihuoya:vulkan-index-buffer branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment