New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always clean cache on render swap #7626

Merged
merged 1 commit into from Jan 8, 2019

Conversation

2 participants
@weihuoya
Copy link
Contributor

weihuoya commented Dec 17, 2018

Xenoblade will crash at launch on android when use vulkan backend because of out of memory.
fbHeight is 0 at launch and can't get in SwapImpl.

Show resolved Hide resolved Source/Core/VideoCommon/RenderBase.h Outdated
Show resolved Hide resolved Source/Core/VideoBackends/Vulkan/Renderer.cpp Outdated
Show resolved Hide resolved Source/Core/VideoBackends/OGL/Render.cpp Outdated
Show resolved Hide resolved Source/Core/VideoBackends/OGL/Render.cpp Outdated

@weihuoya weihuoya force-pushed the weihuoya:vulkan-oom branch 2 times, most recently from 0bf9006 to f697d3f Jan 3, 2019

@weihuoya weihuoya force-pushed the weihuoya:vulkan-oom branch from f697d3f to 66a7db3 Jan 8, 2019

@stenzek

stenzek approved these changes Jan 8, 2019

Copy link
Contributor

stenzek left a comment

LGTM

@stenzek stenzek merged commit 0da5929 into dolphin-emu:master Jan 8, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment