Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerPC: Factor out CR helpers into POD class #7637

Merged
merged 1 commit into from Mar 13, 2019

Conversation

3 participants
@CrystalGamma
Copy link

CrystalGamma commented Dec 23, 2018

Prep work for removing the ppcState global variable.

I decided to put the methods of ConditionRegister after the data members like in UReg_FPSCR because they are both POD types with methods (and I think the order described in the guidelines makes more sense for abstract data types). If you insist I'm open to changing it though.

@CrystalGamma CrystalGamma force-pushed the CrystalGamma:pr-crhelpers branch from e7204ba to e9db098 Dec 23, 2018

u64 fields[8];

// Convert between PPC and internal representation of CR.
static inline u64 PPCToInternal(u8 value)

This comment has been minimized.

@lioncash

lioncash Dec 23, 2018

Member

Functions defined in a class/struct/union declaration don't need to be declared inline. They're already inline by default. Ditto for other relevant occurrences.


#include "Core/PowerPC/ConditionRegister.h"

const std::array<u64, 16> PowerPC::ConditionRegister::s_crTable = {{

This comment has been minimized.

@lioncash

lioncash Dec 23, 2018

Member

This files' contents should be placed within a

namespace PowerPC
{

}  // namespace PowerPC

block instead of writing out PowerPC:: everywhere it's necessary.

@CrystalGamma CrystalGamma changed the title factor out CR helpers into POD class PowerPC: Factor out CR helpers into POD class Dec 24, 2018

@CrystalGamma CrystalGamma force-pushed the CrystalGamma:pr-crhelpers branch from 6e0e0f9 to e3075f3 Mar 8, 2019

@Tilka Tilka merged commit 7b354fa into dolphin-emu:master Mar 13, 2019

9 of 10 checks passed

pr-osx-x64 Build failed on builder pr-osx-x64
Details
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@CrystalGamma CrystalGamma deleted the CrystalGamma:pr-crhelpers branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.