New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Emulated Dance Mat #7656

Merged
merged 1 commit into from Jan 7, 2019

Conversation

3 participants
@JMC47
Copy link
Contributor

JMC47 commented Dec 28, 2018

I have no idea how it got so broken, but this makes it so both the
Active Life and DDR Mario/Wii games can be fully configured.

I have no idea how they got so broken but now you can actually play the games without needing Native GC Support and a Dance Mat (which doesn't work for Active Life). I also noted that some of the buttons are only on the Active Life Mat, I have 4 official Dance Mats (DDR Hottest Party 1, DDR Hottest Party 2, DDR Mario, and Active Life Mat) and hardware tested the button values with assistance from Booto.

Note: Someone still needs to make an "Dance Mat" option for Native GC Support for the games to actually notice you have a Dance Mat plugged in. This is purely to fix Emulated Dance Mat support.

@jordan-woyak

This comment has been minimized.

Copy link
Contributor

jordan-woyak commented Dec 28, 2018

Double spacing after periods in your comments! D: Did you write this code on a typewriter? :P

@JMC47

This comment has been minimized.

Copy link
Contributor

JMC47 commented Dec 28, 2018

I learned to type on typewriter because U.S. schools are poor, so yeah.

Fix Emulated Dance Mat
I have no idea how it got so broken, but this makes it so both the
Active Life and DDR Mario/Wii games can be fully configured.

@JMC47 JMC47 force-pushed the JMC47:DanceMatFix branch from e1fab14 to f8586bb Dec 28, 2018

@Helios747 Helios747 merged commit c73adf8 into dolphin-emu:master Jan 7, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment