New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControllerEmu: Killed the button group threshold setting. #7664

Merged
merged 1 commit into from Jan 16, 2019

Conversation

3 participants
@jordan-woyak
Copy link
Contributor

jordan-woyak commented Dec 31, 2018

I've removed the "Threshold" setting from button groups and hard-coded it to 50%.
Why?

  • It clutters up the mapping dialogs a lot, especially the hotkeys dialog.
  • Isn't this nicer? https://i.imgur.com/G5qupLf.png
  • It does absolutely nothing when mapping a digital button which is the case 99% of the time.
  • People probably don't even know what it does (the Qt mapping indicator wasn't even using it).
  • The only time it was useful was mapping analog sticks to directional buttons and desiring to tweak the amount of analog movement required.
  • You can still accomplish the same thing by adjusting the "Range" sliders in the right-click menu.
  • Or in my expression-parser-improve PR you can use the greater-than sign: `Button`>'0.4'

I've also made the red button indicators use the threshold to accurately show activation.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:kill-button-threshold branch from de5926d to df43fd9 Dec 31, 2018

@master0fdisaster

This comment has been minimized.

Copy link
Contributor

master0fdisaster commented Jan 1, 2019

What about the GC controller triggers? Having the threshold setting for mapping analog-only triggers to the GC controller's analog/digital combo triggers is really useful. And a hardcoded value of 50 would be really impractical and limiting in many games.

@jordan-woyak

This comment has been minimized.

Copy link
Contributor

jordan-woyak commented Jan 1, 2019

@master0fdisaster Don't worry. The trigger threshold is still there. I know that it's important. ;)

@leoetlino
Copy link
Member

leoetlino left a comment

Sounds fine to me.

@leoetlino leoetlino merged commit e19ee2a into dolphin-emu:master Jan 16, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment