New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetSysDirectory() always ends with a / #7676

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@i30817
Copy link

i30817 commented Jan 5, 2019

Noticed a additional / in the message

[libretro INFO] 02:59:530 Core/HW/DSPHLE/UCodes/AX.cpp:64 I[DSPHLE]: Loading polyphase resampling coeffs from /home/i30817/.config/retroarch/bios/dolphin-emu/Sys//GC/dsp_coef.bin

When i was trying to debug a different bug on eternal darkness.

The dir separator is added here:

sysDir += DIR_SEP;

So this one is extra. Probably. Maybe i'm being dumb though, so review this one character change.

GetSysDirectory() always ends with a /
Noticed a additional / in the message 

`[libretro INFO] 02:59:530 Core/HW/DSPHLE/UCodes/AX.cpp:64 I[DSPHLE]: Loading polyphase resampling coeffs from /home/i30817/.config/retroarch/bios/dolphin-emu/Sys/GC/dsp_coef.bin`

When i was trying to debug a different bug on eternal darkness.

The dir separator is added here:
https://github.com/dolphin-emu/dolphin/blob/fc998093cce1e2876e776bdede807887cb979a17/Source/Core/Common/FileUtil.cpp#L736

So this one is extra. Probably.
@BhaaLseN

This comment has been minimized.

Copy link
Member

BhaaLseN commented Jan 6, 2019

Good catch! I wonder if this should be using GC_SYS_DIR and DSP_COEF from CommonPaths.h though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment