New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/Debugger Memory widget features #7678

Open
wants to merge 2 commits into
base: master
from

Conversation

2 participants
@TryTwo
Copy link
Contributor

TryTwo commented Jan 5, 2019

Memory widget new features:
2 column style view (same as Wx builds).
Shift click to send memory address to address box.
Crtl click to send data to data box.

Restoring the 2-column view from Wx has been request by a few people and is quite useful. Dealing with both styles in the code looks a little sloppy though, if anyone has suggestions on clearing that up. Maybe just using more if statements?

/edit Removed:
Float <-> Hex converter. We had the space and it's quite useful.
Offset box next to address box.

@TryTwo TryTwo force-pushed the TryTwo:Debugger_Memory_Features branch from 5fd2498 to 5d23e99 Jan 8, 2019

@TryTwo

This comment has been minimized.

Copy link
Contributor

TryTwo commented Jan 17, 2019

I think I can remove the float - hex conversion because I added float input in another PR with a preview box that shows the hex that will be written. Basically a float -> hex converter, but minus the hex -> float ability.

I can probably remove the memory address offset box unless other people think it'd be helpful. I originally made it to quickly navigate to load/store locations that use offsets, but now you can just right click the instruction and send the memory location to the memory address box (different PR).

@TryTwo TryTwo force-pushed the TryTwo:Debugger_Memory_Features branch from 5d23e99 to f707ad2 Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment