New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to select visibility of game list columns by right clicking game list header #7685

Open
wants to merge 2 commits into
base: master
from

Conversation

4 participants
@yousifd
Copy link

yousifd commented Jan 8, 2019

Ability to select visibility of game list columns by right clicking the game list header

Fixes issue: https://bugs.dolphin-emu.org/issues/11429

@JMC47

This comment has been minimized.

Copy link
Contributor

JMC47 commented Jan 8, 2019

@spycrab please review.

@spycrab

spycrab approved these changes Jan 8, 2019

Copy link
Contributor

spycrab left a comment

LGTM

@BhaaLseN
Copy link
Member

BhaaLseN left a comment

Please address the Lint issue when you it is most convinient for you.

@@ -390,6 +393,39 @@ void GameList::ShowContextMenu(const QPoint&)
menu->exec(QCursor::pos());
}

void GameList::ShowHeaderContextMenu(const QPoint&)
{
static const QMap<QString, bool*> columns{

This comment has been minimized.

@BhaaLseN

BhaaLseN Jan 8, 2019

Member

Since this is the same one as MenuBar::AddListColumnsMenu, can (or should!) we move that to a shared location instead?

This comment has been minimized.

@yousifd

yousifd Jan 8, 2019

I thought the same but I didn't know where to put it. I could move it to Settings.cpp as a private static variable and add a getter method. Both GameList.cpp and MenuBar.cpp inherit from Settings.cpp

My only issue is that I don't think that's the purpose of Settings.cpp. Do you have any suggestions of where I could move it to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment