New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControllerInterface: Hotplug callback fixes. #7693

Merged
merged 1 commit into from Jan 16, 2019

Conversation

2 participants
@jordan-woyak
Copy link
Contributor

jordan-woyak commented Jan 10, 2019

Allow hotplug callbacks to be unregistered (previously we were just adding duplicate callbacks every init/shutdown cycle)

Don't reload the entire config from file on a hotplug event, just update the control references.

This should fix a crash on shutdown on Android.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:hotplug-callback-fix branch from f2d5de8 to 09b9e25 Jan 10, 2019

ControllerInterface: Allow hotplug callbacks to be unregistered and d…
…on't reload the entire config from the ini file on hotplug, just update the control references. This should fix a crash on shutdown on Android.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:hotplug-callback-fix branch from 09b9e25 to b425f86 Jan 11, 2019

@leoetlino leoetlino merged commit a8bc6f9 into dolphin-emu:master Jan 16, 2019

10 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-osx-x64 Build succeeded on builder pr-osx-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@jordan-woyak jordan-woyak deleted the jordan-woyak:hotplug-callback-fix branch Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment