New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt/Debugger Code View: Uses font based sizing and whitespace #7697

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@TryTwo
Copy link
Contributor

TryTwo commented Jan 12, 2019

Row height is now based on font size, allows more rows to fit on screen.
Added whitespace for padding. Also sets a minimum size for columns to reduce frequent resizing while scrolling. Some resizing still allowed.
Fixed the scrollbar to always work, allowing you to read the symbol text to the end.

@TryTwo

This comment has been minimized.

Copy link
Contributor

TryTwo commented Jan 12, 2019

I just noticed there was a bit of lag introduced, possibly due to removing:
horizontalHeader()->setStretchLastSection(true);
Its removal allows the scrollbars to work correctly.

This seems fixable by removing all
horizontalHeader()->setSectionResizeMode(i, QHeaderView::ResizeToContents);
and relying on resizeColumnsToContents(); at the bottom of the update loop.

I'll test it for a bit to make sure that's not buggy.

@TryTwo TryTwo force-pushed the TryTwo:Debugger_UI_CodeView_Font_Based_Sizing branch from a280e14 to 0f07333 Jan 12, 2019

@TryTwo

This comment has been minimized.

Copy link
Contributor

TryTwo commented Jan 12, 2019

Removed all horizontalHeader()->setSectionResizeMode(i, QHeaderView::ResizeToContents); due to lag. See no visual difference without it.

Prevented scrollbar from snapping to columns,
Slightly resized BP column/icon to prevent the column from resizing itself when a BP is set.
Changed leftJustified to an .arg() because it seemed a bit laggier than arg().

Don't notice any lag now.

@TryTwo TryTwo changed the title Qt/Debugger CodeVIew: Uses font based sizing and whitespace Qt/Debugger Code View: Uses font based sizing and whitespace Jan 12, 2019

Debugger CodeVIew: Uses font based sizing for row height. Fits more r…
…ows on screen.

Adds whitespace for better formatting and minimum column width. Helps prevent frequent resizing while scrolling.

@TryTwo TryTwo force-pushed the TryTwo:Debugger_UI_CodeView_Font_Based_Sizing branch from 0f07333 to 1775253 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment