Remove the Console from the possible logging options. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Good, I never knew wtf it was for <_< |
|
I didn't even know about that. LGTM. |
Note I do not mean the Logging window, but the console window. It's literally rarely, if at all used, and offers less advantages over the built-in logging window (ie. it breaks on different locales: http://i.imgur.com/Cs92tQE.png) This commit should remove all of the console logging.
delroth
added a commit
that referenced
this pull request
Feb 17, 2014
Remove the Console from the possible logging options.
delroth
added a commit
that referenced
this pull request
Feb 23, 2014
This breaks Linux stdout logging. This reverts commit 7ac5b1f, reversing changes made to 9bc1401. Revert "Merge pull request #77 from lioncash/remove-console" This reverts commit 9bc1401, reversing changes made to b18a333. Conflicts: Source/Core/Common/LogManager.cpp Source/Core/DolphinWX/Frame.cpp Source/Core/DolphinWX/FrameAui.cpp Source/Core/DolphinWX/LogConfigWindow.cpp Source/Core/DolphinWX/LogWindow.cpp
lioncash
pushed a commit
to lioncash/dolphin
that referenced
this pull request
Mar 3, 2014
This breaks Linux stdout logging. This reverts commit 7ac5b1f, reversing changes made to 9bc1401. Revert "Merge pull request dolphin-emu#77 from lioncash/remove-console" This reverts commit 9bc1401, reversing changes made to b18a333. Conflicts: Source/Core/Common/LogManager.cpp Source/Core/DolphinWX/Frame.cpp Source/Core/DolphinWX/FrameAui.cpp Source/Core/DolphinWX/LogConfigWindow.cpp Source/Core/DolphinWX/LogWindow.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Note I do not mean the Logging window, but the console window.
It's literally rarely, if at all used, and offers little advantage over the built-in logging window (ie. it breaks on different locales: http://i.imgur.com/Cs92tQE.png)
Not to mention this is Windows only.