New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] DSP: ARAM cleanup experiments #7740

Open
wants to merge 3 commits into
base: master
from

Conversation

6 participants
@booto
Copy link
Contributor

booto commented Jan 26, 2019

Some experiments trying to clean up ARAM-related code that seems strange.

@booto booto force-pushed the booto:aram-experiments branch from 65d28b8 to d0a7211 Jan 26, 2019

@shuffle2

This comment has been minimized.

Copy link
Contributor

shuffle2 commented Jan 26, 2019

did you check git blame? nvm lgtm

@booto booto force-pushed the booto:aram-experiments branch from 6222200 to 60b7c37 Jan 29, 2019

Show resolved Hide resolved Source/Core/Core/HW/DSP.cpp Outdated

@booto booto force-pushed the booto:aram-experiments branch 2 times, most recently from 7ff09ee to 1bb7392 Jan 29, 2019

@JMC47

This comment has been minimized.

Copy link
Contributor

JMC47 commented Jan 29, 2019

This fixes the remaining issues in ATV Offroad Fury 2 in multiplayer.

s_arDMA.ARAddr += 8;
s_arDMA.Cnt.count -= 8;
std::memcpy(Memory::GetPointer(s_arDMA.MMAddr), &s_ARAM.ptr[*physical_aram_addr],
ARAM_LINE_SIZE);

This comment has been minimized.

@BhaaLseN

BhaaLseN Jan 29, 2019

Member

It seems the outer if/else branches each have the same for loop that only differs in the first line of the inner if/else branches.
Would it be worthwhile to pull the loop up (writing it just once) and pushing the outer if/else inside (which would become a "pick source/dest" for the physical_aram_addr case; and a conditional "do/don't" otherwise)?

@booto booto force-pushed the booto:aram-experiments branch 3 times, most recently from 653764b to 4464aa3 Jan 30, 2019

@endrift

This comment has been minimized.

Copy link
Contributor

endrift commented Jan 31, 2019

Wonder if this will fix my HSP issues. Poke me when this is done and I'll rewrite my HSP branch on top of it to find out.

booto added some commits Jan 26, 2019

ARAM: rework DMA
Changes include:
  * Take into account how different size settings interact
  * Do ARAM DMA transfers in chunks rather than all-at-once

@booto booto force-pushed the booto:aram-experiments branch from 4464aa3 to a39e0d4 Feb 1, 2019

@gandalfthewhite19890404

This comment has been minimized.

Copy link

gandalfthewhite19890404 commented Feb 15, 2019

Seems it fixes Resident Evil 2 sound issues, at least for me. Need more testers, also for Residen Evil 3 Nemesis.

@JMC47

This comment has been minimized.

Copy link
Contributor

JMC47 commented Feb 15, 2019

The broken sound in the intro is still there for me in Resident Evil 2. I haven't tested any areas beyond that, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment