New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Minor text tweaks #7752

Merged
merged 1 commit into from Feb 7, 2019

Conversation

5 participants
@8times9
Copy link
Contributor

8times9 commented Jan 27, 2019

Tweaks text largely in the graphics config descriptions but also some in the general config.

The idea is to have all of the option descriptions worded with an implied "This option" at the beginning, hence all of the changes to singular verb form.

@BhaaLseN
Copy link
Member

BhaaLseN left a comment

Most changes look sensible to me, but I'm not a native speaker. Maybe @MayImilae could weigh in on them?

@8times9 8times9 force-pushed the 8times9:text-tweaks branch 2 times, most recently from a72feb2 to 9b88273 Jan 28, 2019

@Tilka

This comment has been minimized.

Copy link
Member

Tilka commented Feb 2, 2019

Please fix the lint issues. Maybe try temporarily enabling the BreakStringLiterals option to have clang-format do it for you. Looks good otherwise.

@8times9 8times9 force-pushed the 8times9:text-tweaks branch from 3ee8f65 to c018caa Feb 2, 2019

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 2, 2019

@Tilka Done

@Tilka

This comment has been minimized.

Copy link
Member

Tilka commented Feb 3, 2019

Small lint complaints remaining.

@8times9 8times9 force-pushed the 8times9:text-tweaks branch from c018caa to 192806f Feb 3, 2019

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 3, 2019

Odd, I don't remember lint complaining about those last time. Fixed.

I also found a typo in AdvancedWidget and fixed it.
TR_TEXTURE_FORMAT_DECRIPTION --> TR_TEXTURE_FORMAT_DESCRIPTION

@MayImilae
Copy link
Contributor

MayImilae left a comment

Excellent changes! More even tenses and less uses of "you" is all very good! I have a couple of comments, but this is all positive imo!

@8times9 8times9 force-pushed the 8times9:text-tweaks branch from 192806f to ccce0df Feb 3, 2019

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 3, 2019

@MayImilae I fixed your nitpicks

@8times9 8times9 changed the title Qt: Minor text tweaks WIP Qt: Minor text tweaks Feb 3, 2019

@8times9 8times9 force-pushed the 8times9:text-tweaks branch from ccce0df to 63940d9 Feb 3, 2019

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 3, 2019

Sorry for all of the new changes, I decided to apply your input from #7196

Let me know if there's anything else you'd like to see changed!

@8times9 8times9 changed the title WIP Qt: Minor text tweaks Qt: Minor text tweaks Feb 3, 2019

@MayImilae
Copy link
Contributor

MayImilae left a comment

Still good changes! Keep it up! I have a couple more little notes on ways it could be a little better though.

@8times9 8times9 force-pushed the 8times9:text-tweaks branch from 1162d56 to 3ed2005 Feb 7, 2019

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 7, 2019

@MayImilae Okay, I fixed those two issues

@MayImilae
Copy link
Contributor

MayImilae left a comment

Great improvements!

@8times9 8times9 force-pushed the 8times9:text-tweaks branch from 3ed2005 to e0aa047 Feb 7, 2019

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 7, 2019

Sorry, I squeezed in one last commit to add a period haha. That should be everything.

@MayImilae

This comment has been minimized.

Copy link
Contributor

MayImilae commented Feb 7, 2019

You'll need fix all lint errors before this can be merged.

@8times9 8times9 force-pushed the 8times9:text-tweaks branch from e0aa047 to d45dad7 Feb 7, 2019

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 7, 2019

Done

@Helios747

This comment has been minimized.

Copy link
Contributor

Helios747 commented Feb 7, 2019

@Helios747 Helios747 merged commit 2987e83 into dolphin-emu:master Feb 7, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@8times9 8times9 deleted the 8times9:text-tweaks branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment