Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official flag for detailed symbols. Require VS2013 with update 3 or later to build. #777

Merged
merged 1 commit into from Aug 12, 2014
Merged

Conversation

shuffle2
Copy link
Contributor

No description provided.

@shuffle2
Copy link
Contributor Author

/Zo is new to VS2013 with update 3, but requiring that compiler version or later also prevents users reporting bugs which have been fixed in VS updates (thus wasting our time).

@delroth
Copy link
Member

delroth commented Aug 10, 2014

Is there by any chance a way to get this version requirement into the
vcxproj file?
On Aug 10, 2014 2:52 PM, "shuffle2" notifications@github.com wrote:

/Zo is new to VS2013 with update 3, but requiring that compiler version or
later also prevents users reporting bugs which have been fixed in VS
updates (thus wasting our time).


Reply to this email directly or view it on GitHub
#777 (comment).

@shuffle2
Copy link
Contributor Author

I spent ~5minutes and couldn't see an (easy) way to put a cl version check into msbuild, although I'm sure there is some way...

Making the precompiled headers better is still a thing I need to do...so hopefully soon it won't just be "random check in one of the many stdafx.h".

@shuffle2
Copy link
Contributor Author

I guess it depends if you want to rely on msbuild version being tied to compiler version. If yes, it's easy...but I wouldn't want to rely on that.

@Tilka
Copy link
Member

Tilka commented Aug 10, 2014

lgtm

@lioncash
Copy link
Member

Looks good to me

@delroth
Copy link
Member

delroth commented Aug 11, 2014

LGTM too, please make sure our build documentation is up to date and
mentions (in some kind of FAQ section) what happens if you are building
with an old version and how to fix it (install this package, etc.)

Thanks!
On Aug 11, 2014 4:17 PM, "Lioncash" notifications@github.com wrote:

Looks good to me


Reply to this email directly or view it on GitHub
#777 (comment).

@lioncash
Copy link
Member

Updated the necessary wiki links. shuffle2 could probably do the FAQ if necessary.

shuffle2 added a commit that referenced this pull request Aug 12, 2014
Use official flag for detailed symbols. Require VS2013 with update 3 or later to build.
@shuffle2 shuffle2 merged commit 36af1b5 into dolphin-emu:master Aug 12, 2014
@shuffle2 shuffle2 deleted the vs2013-update3 branch August 12, 2014 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants