New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiimoteEmu: Change speaker pan to use "constant power pan law". #7782

Merged
merged 1 commit into from Feb 11, 2019

Conversation

5 participants
@jordan-woyak
Copy link
Member

jordan-woyak commented Feb 4, 2019

This is a re-implementation of @kamiyo's PR #3474.

A constant power pan law is audibly more pleasing than linear, since linear makes signals panned to the center seem softer than those panned either all the way to the left or all the way to the right. See: http://www.rs-met.com/documents/tutorials/PanRules.pdf

-kamiyo

I've also changed the UI pan setting from a -127..127 range to -100..100.
There's no need to expose the internals of our mixer.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:wiimote-emu-speaker-pan branch from 7fbc973 to c14b25e Feb 4, 2019

@kamiyo

This comment has been minimized.

Copy link
Contributor

kamiyo commented Feb 4, 2019

Thanks for taking up the mantle!

@shuffle2

This comment has been minimized.

Copy link
Contributor

shuffle2 commented Feb 4, 2019

I thought dolphin was against functional-style casts? lgtm otherwise

@BhaaLseN

This comment has been minimized.

Copy link
Member

BhaaLseN commented Feb 4, 2019

They are shorter than the static_cast equivalent, but from what I read on cppreference (2) after being slightly suspicious they would be equivalent to a C-style cast? I'm pretty sure thats not what we want.

@jordan-woyak

This comment has been minimized.

Copy link
Member Author

jordan-woyak commented Feb 4, 2019

Yeah. But it's an integer. It's clear that it's a static cast. Static_cast is so verbose. It's sensible for pointers though.

WiimoteEmu: Change speaker pan to use "constant power pan law" and ch…
…ange UI setting max value from 127 to 100.

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:wiimote-emu-speaker-pan branch from c14b25e to 3c77b4a Feb 10, 2019

@Tilka Tilka merged commit 4d85bb2 into dolphin-emu:master Feb 11, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment