Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiimoteEmu: Change speaker pan to use "constant power pan law". #7782

Merged
merged 1 commit into from Feb 11, 2019

Conversation

jordan-woyak
Copy link
Member

This is a re-implementation of @kamiyo's PR #3474.

A constant power pan law is audibly more pleasing than linear, since linear makes signals panned to the center seem softer than those panned either all the way to the left or all the way to the right. See: http://www.rs-met.com/documents/tutorials/PanRules.pdf

-kamiyo

I've also changed the UI pan setting from a -127..127 range to -100..100.
There's no need to expose the internals of our mixer.

@kamiyo
Copy link
Contributor

kamiyo commented Feb 4, 2019

Thanks for taking up the mantle!

@shuffle2
Copy link
Contributor

shuffle2 commented Feb 4, 2019

I thought dolphin was against functional-style casts? lgtm otherwise

@BhaaLseN
Copy link
Member

BhaaLseN commented Feb 4, 2019

They are shorter than the static_cast equivalent, but from what I read on cppreference (2) after being slightly suspicious they would be equivalent to a C-style cast? I'm pretty sure thats not what we want.

@jordan-woyak
Copy link
Member Author

Yeah. But it's an integer. It's clear that it's a static cast. Static_cast is so verbose. It's sensible for pointers though.

@Tilka Tilka merged commit 4d85bb2 into dolphin-emu:master Feb 11, 2019
@jordan-woyak jordan-woyak deleted the wiimote-emu-speaker-pan branch February 21, 2019 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants