New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Make the mapping window clear button use ControllerEmu's clear functionality. #7788

Merged
merged 1 commit into from Feb 10, 2019

Conversation

3 participants
@jordan-woyak
Copy link
Member

jordan-woyak commented Feb 6, 2019

Rather than sending a clear signal to all the widgets we can directly clear the controller and just update the UI. (This is what the WxWidgets dialog did and is what the "Default" button basically does)

This makes the "Clear" button complete instantly instead of taking seconds while every single widget calls SaveSettings().

It also no longer forces newly added widget types to implement their own clear functionality. (which is what I ran into causing me to become irate)

@BhaaLseN
Copy link
Member

BhaaLseN left a comment

Sounds like a sensible idea, code seems fine. Untested tho, so I can't say if this approach has any side effects.

@Tilka

This comment has been minimized.

Copy link
Member

Tilka commented Feb 10, 2019

Tested before and after, works.

@Tilka Tilka merged commit 226affe into dolphin-emu:master Feb 10, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment