Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Qt: Set MappingIndicator background to transparent #7789
The contrast of white-on-dark in master is definitely unfortunate for dark themes and your change might look better there but I don't think this is the proper solution as it is going to make things look gross with off-white backgrounds. I think we should be able to query some sane values from Qt to work in every case.
E.g. BBOX_BRUSH_COLOR should probably be the same as a textbox background. This would make it white for a typical light theme and a dark for you. We will need to change the other color constants accordingly.
@jordan-woyak Yeah, I figured this wasn't a perfect solution, I just thought it might be better than nothing for now. I don't have the coding knowledge for proper solution like what you talked about haha, I'll just file an issue on the bug tracker.
@BhaaLseN I agree, it should probably be a little brighter.