New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Set MappingIndicator background to transparent #7789

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@8times9
Copy link
Contributor

8times9 commented Feb 7, 2019

Makes MappingIndicators look much better with custom styles or macOS dark mode.

Before:
before

After:
after

@jordan-woyak

This comment has been minimized.

Copy link
Member

jordan-woyak commented Feb 7, 2019

The contrast of white-on-dark in master is definitely unfortunate for dark themes and your change might look better there but I don't think this is the proper solution as it is going to make things look gross with off-white backgrounds. I think we should be able to query some sane values from Qt to work in every case.

E.g. BBOX_BRUSH_COLOR should probably be the same as a textbox background. This would make it white for a typical light theme and a dark for you. We will need to change the other color constants accordingly.

@BhaaLseN

This comment has been minimized.

Copy link
Member

BhaaLseN commented Feb 7, 2019

Was about to comment something similar about how the faint light gray looks odd on the analog indicators with that dark gray background...this could probably use some more coordination to get some better visibility.

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 7, 2019

@jordan-woyak Yeah, I figured this wasn't a perfect solution, I just thought it might be better than nothing for now. I don't have the coding knowledge for proper solution like what you talked about haha, I'll just file an issue on the bug tracker.

@BhaaLseN I agree, it should probably be a little brighter.

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 7, 2019

Done: #11559

@8times9

This comment has been minimized.

Copy link
Contributor Author

8times9 commented Feb 18, 2019

Succeeded by @jordan-woyak's #7807

@8times9 8times9 closed this Feb 18, 2019

@8times9 8times9 deleted the 8times9:transparent-indicator branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment