Qt: Set MappingIndicator background to transparent #7789
Conversation
|
The contrast of white-on-dark in master is definitely unfortunate for dark themes and your change might look better there but I don't think this is the proper solution as it is going to make things look gross with off-white backgrounds. I think we should be able to query some sane values from Qt to work in every case. E.g. BBOX_BRUSH_COLOR should probably be the same as a textbox background. This would make it white for a typical light theme and a dark for you. We will need to change the other color constants accordingly. |
|
Was about to comment something similar about how the faint light gray looks odd on the analog indicators with that dark gray background...this could probably use some more coordination to get some better visibility. |
|
@jordan-woyak Yeah, I figured this wasn't a perfect solution, I just thought it might be better than nothing for now. I don't have the coding knowledge for proper solution like what you talked about haha, I'll just file an issue on the bug tracker. @BhaaLseN I agree, it should probably be a little brighter. |
|
Done: #11559 |
|
Succeeded by @jordan-woyak's #7807 |
Makes MappingIndicators look much better with custom styles or macOS dark mode.
Before:
After:
