New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Show files in the directory picker #7791

Merged
merged 1 commit into from Feb 16, 2019

Conversation

4 participants
@JosJuice
Copy link
Contributor

JosJuice commented Feb 7, 2019

People in the Google Play reviews still seem to be confused about games not showing up in the directory picker, so let's show them even though they can't be selected. (Either that or they haven't realized that they need to extract their pirated games.)

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

JosJuice commented Feb 7, 2019

It works, but the directory picker shows checkboxes that let you select files, even though those selections don't end up being used for anything... Kinda awkward.

@JosJuice JosJuice force-pushed the JosJuice:android-show-files branch from 3080ca0 to 3ae75b7 Feb 7, 2019

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

JosJuice commented Feb 7, 2019

Got rid of the checkboxes by overriding isCheckable. This PR should be good to go now.

@JosJuice JosJuice force-pushed the JosJuice:android-show-files branch from 3ae75b7 to c95bd5e Feb 8, 2019

Android: Show files in the directory picker
People in the Google Play reviews still seem to be confused about
games not showing up in the directory picker, so let's show them
even though they can't be selected. (Either that or they haven't
realized that they need to extract their pirated games.)

@JosJuice JosJuice force-pushed the JosJuice:android-show-files branch from c95bd5e to c520a03 Feb 8, 2019

@JosJuice

This comment has been minimized.

Copy link
Contributor Author

JosJuice commented Feb 13, 2019

@zackhow Are you okay with this change?

@zackhow
Copy link
Member

zackhow left a comment

LGTM

@JosJuice JosJuice merged commit 286aafd into dolphin-emu:master Feb 16, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@JosJuice JosJuice deleted the JosJuice:android-show-files branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment