Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAndroid: Show files in the directory picker #7791
+35
−3
Conversation
This comment has been minimized.
This comment has been minimized.
|
It works, but the directory picker shows checkboxes that let you select files, even though those selections don't end up being used for anything... Kinda awkward. |
JosJuice
force-pushed the
JosJuice:android-show-files
branch
from
3080ca0
to
3ae75b7
Feb 7, 2019
This comment has been minimized.
This comment has been minimized.
|
Got rid of the checkboxes by overriding |
JosJuice
force-pushed the
JosJuice:android-show-files
branch
from
3ae75b7
to
c95bd5e
Feb 8, 2019
BhaaLseN
approved these changes
Feb 8, 2019
JosJuice
force-pushed the
JosJuice:android-show-files
branch
from
c95bd5e
to
c520a03
Feb 8, 2019
This comment has been minimized.
This comment has been minimized.
|
@zackhow Are you okay with this change? |
JosJuice
merged commit 286aafd
into
dolphin-emu:master
Feb 16, 2019
9 checks passed
default
Very basic checks passed, handed off to Buildbot.
Details
lint
Build succeeded on builder lint
Details
pr-android
Build succeeded on builder pr-android
Details
pr-deb-dbg-x64
Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64
Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64
Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64
Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64
Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64
Build succeeded on builder pr-win-x64
Details
JosJuice
deleted the
JosJuice:android-show-files
branch
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
JosJuice commentedFeb 7, 2019
People in the Google Play reviews still seem to be confused about games not showing up in the directory picker, so let's show them even though they can't be selected. (Either that or they haven't realized that they need to extract their pirated games.)