New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChunkFile: Don't access element zero of empty container #7797

Merged
merged 1 commit into from Feb 10, 2019

Conversation

2 participants
@stenzek
Copy link
Contributor

stenzek commented Feb 10, 2019

This was causing assertion failures in debug MSVC builds.

ChunkFile: Don't access element zero of empty container
This was causing assertion failures in debug MSVC builds.
@Tilka

This comment has been minimized.

Copy link
Member

Tilka commented Feb 10, 2019

Just fyi, the proper fix would be to use non-const .data() but that didn't work on our Android builder.

@Tilka Tilka merged commit 3a36f73 into dolphin-emu:master Feb 10, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details
@stenzek

This comment has been minimized.

Copy link
Contributor Author

stenzek commented Feb 11, 2019

Ah. More workarounds because of the NDK compiler/library :(

@stenzek stenzek deleted the stenzek:chunkfile branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment