Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Apply hiding logic earlier (macOS) #7833

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@chargeflux
Copy link
Contributor

chargeflux commented Feb 28, 2019

On macOS, if the Debugging UI is enabled but the "Code" window is closed (made not visible by the user), every time Dolphin is launched, the "Code" window is shown and then hidden very quickly because of the hiding logic. This is a quick fix to move the hiding logic earlier so that the flicker doesn't happen. Note that the Code window has to be detached for this bug to happen.

@chargeflux

This comment has been minimized.

Copy link
Contributor Author

chargeflux commented Mar 1, 2019

Just realized this applies to the rest of the Debugging windows. Should I expand the scope of this PR?

@jordan-woyak

This comment has been minimized.

Copy link
Member

jordan-woyak commented Mar 1, 2019

@chargeflux Sounds fine to me. More related changes.

Another thought. You should probably add a comment stating that the window needs to be hidden before setFloating to prevent issue on macOS. Otherwise someone not on macOS is bound to accidentally undo this later.

@chargeflux chargeflux force-pushed the chargeflux:CodeWidgetHiding-macOS branch from 0bf3546 to 797e5f4 Mar 1, 2019

@chargeflux chargeflux changed the title CodeWidget: Apply hiding logic earlier (macOS) Debugger: Apply hiding logic earlier (macOS) Mar 1, 2019

@chargeflux

This comment has been minimized.

Copy link
Contributor Author

chargeflux commented Mar 1, 2019

Changed the relevant files and added a comment before setFloating

@chargeflux chargeflux force-pushed the chargeflux:CodeWidgetHiding-macOS branch from 797e5f4 to 165d5ff Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.