Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Move the 'Display' settings from ConfigManager to the layered config system #7841

Open
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@iwubcode
Copy link
Contributor

iwubcode commented Mar 3, 2019

I've been looking into emulator front-ends lately and wanted to put games into fullscreen when playing a game with Dolphin. Unfortunately, the fullscreen option was using the old config system while the command-line support for arbitrary configuration settings was using the new system. The fix was to move all the Display settings over to the new system.

Should fix:

Issue 9091
Issue 10735

@iwubcode iwubcode force-pushed the iwubcode:config-mgr-onion branch 5 times, most recently from 58e3eca to 75d49aa Mar 3, 2019

@iwubcode iwubcode force-pushed the iwubcode:config-mgr-onion branch from 75d49aa to e33b607 Mar 3, 2019

@iwubcode iwubcode force-pushed the iwubcode:config-mgr-onion branch from e33b607 to a164d59 Mar 3, 2019

@BhaaLseN
Copy link
Member

BhaaLseN left a comment

Untested, but code looks good.

More of an aside, but this doesn't perform any migration from the older config system, does it? Or do we have an interim layer for the old config until everything is moved over?

@iwubcode

This comment has been minimized.

Copy link
Contributor Author

iwubcode commented Mar 3, 2019

@BhaaLseN - see GameConfigLoader.cpp 's INIToSectionMap that should handle the migration logic. Also the IsSettingSaveable was supposed to be a temporary fix until everything was ported over (not sure what the replacement would be though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.