Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides toolbar upon using fullscreen and rendering to main window. #787

Merged
merged 2 commits into from Aug 14, 2014
Merged

Hides toolbar upon using fullscreen and rendering to main window. #787

merged 2 commits into from Aug 14, 2014

Conversation

archshift
Copy link
Contributor

This hides the toolbar only when in fullscreen and rendering to the main window.

@shuffle2
Copy link
Contributor

lgtm

@OussamaDanba
Copy link
Contributor

This partially restores behaviour before PR726. The toolbar is gone now however the menu bar stays visible. Mario Kart Double Dash Image

Note: This only happens with Render to Main Window enabled.

@archshift
Copy link
Contributor Author

I'm going to pull the infamous It'sAFeature™ card here, and say that this should be the intended behavior for when you use Render to Main Window as well as Fullscreen. It provides easy access to the (very useful) menu bar even while in fullscreen, without having to alt-tab.

@archshift
Copy link
Contributor Author

I've added another commit disabling the toolbar toggle button in Fullscreen with Render to Main Window.

@OussamaDanba
Copy link
Contributor

LGTM

@neobrain
Copy link
Member

Can you fix the PR summary to not sound like this PR hides the toolbar in windowed render2main window?

@archshift archshift changed the title Hide toolbar upon going fullscreen, rendering to main window. Hides toolbar upon using fullscreen and rendering to main window. Aug 13, 2014
lioncash added a commit that referenced this pull request Aug 14, 2014
Hides toolbar upon using fullscreen and rendering to main window.
@lioncash lioncash merged commit 16a7e6d into dolphin-emu:master Aug 14, 2014
@archshift archshift deleted the fs-toolbar branch August 14, 2014 21:14
@RachelBryk
Copy link
Member

Menu and status bar really really should not be visible in fullscreen. If you want to see these things you shouldn't use fullscreen. The entire point of fullscreen is to hide everything other than the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants