Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
VideoCommon: Change free-look's middle-mouse action to roll the camera. #7870
Hmm, it has a bit of a problem - the angle of the roll is locked to the original camera position/rotation, not the new camera position/rotation. This is a little hard to describe so I'll use screenshots!
So here is the start before using free camera. At this position, roll rotates around like the arrows I added. It's great!
So now I'll WASDQE to move the camera to the edge of the platform on the right, and turn it toward samus with right mouse.
Notice the weird angle? That's why we need roll, that's more or less as good as I could get before and I'd have to fix it in photoshop! Anyway, so now I want to use roll to fix this right? Except, this is the angle of rotation!
So with this, I cannot use roll to correct for the random angles that build up during camera movement. It's locked to whatever the original camera position/rotation was.
...I'm hoping this is easy to solve?
@MayImilae I changed the rotation order so roll occurs after pitch/yaw. Things can still feel weird when pan/tilting after rolling because of the order of rotations. If that is unacceptable I'll have to maintain a rotation matrix instead of the Euler angles.
Hmm... So roll itself works fine now, but all of the other commands ignore it as though those movements never happened. I'm better with images so, visual aids!
After rotating, I'd expect that the movements would still match relative to the frame. So like, holding right mouse and pushing my mouse up would still tilt the window up relative to the frame. Basically I'd expect it to be aware of the roll and factor that into the new position and orientation to start from.
But instead, it ignores the roll, so tilt (holding right mouse) and pan up/down (Shift Q and Shift E) remain at the same orientations they were before the roll. It makes combined camera repositionings for tricky shots a real chore!
Curiously though, Pan left and right (shift A and shift D) DO seem to take the roll into account, and follow the roll of the camera. Very curious!
To be fair, this is still way better than what we've had, and I can genuinely do a lot more shots with this than before. I'd just, need to make sure to do roll changes LAST. It would be nice if that could be addressed though!