Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiimoteReal: Improve state changes and code cleanups. #7871

Open
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@jordan-woyak
Copy link
Member

jordan-woyak commented Mar 9, 2019

Real wiimote code no longer relies on emulated wiimote state to function. (real wiimote packets no longer pass through the emulated wiimote class)

Unbreak sound with real wiimotes and emulated Bluetooth.

Force non-continuous reporting to potentially reduce Bluetooth traffic just a tad.
We duplicate packets to maintain 200hz input so this should have no functional effect.

Loading a save-state now forces a emulated reconnection when using real wiimotes or a source different from that in the savestate.
This is the only foolproof way to make real wiimotes work properly with savestates as we simply do not have enough control over real wiimotes to synchronize their state completely.
(I had to make Wiimote::DoState happen after HW::DoState)

Added unique_ptrs and other minor cleanups.

Fixes issues:
https://bugs.dolphin-emu.org/issues/10912
https://bugs.dolphin-emu.org/issues/11571

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:wm-real-cleanup branch from d57e869 to 95fbd0d Mar 9, 2019

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:wm-real-cleanup branch from 95fbd0d to 0f8b8ad Mar 9, 2019

Show resolved Hide resolved Source/Core/Core/HW/Wiimote.h Outdated
@mbc07

This comment has been minimized.

Copy link
Contributor

mbc07 commented Mar 10, 2019

Wiimote sound is back with emulated Bluetooth, but sadly, for anyone curious, it still a complete mess with non-TR Wiimotes (same as in 5.0 stable, so not a big deal)...

@jordan-woyak jordan-woyak force-pushed the jordan-woyak:wm-real-cleanup branch from 0f8b8ad to 49218c3 Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.