Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModalMessageBox: Remove superfluous buttons and ensure correct parent #7875

Merged
merged 1 commit into from Mar 11, 2019

Conversation

2 participants
@spycrab
Copy link
Contributor

spycrab commented Mar 11, 2019

  • Fixes some message boxes not showing as sheets dispite having the ability to be shown as such
  • Remove window title buttons that are not supposed to be present in message boxes

@spycrab spycrab force-pushed the spycrab:qt_msgbox_fixes branch from b8ada4b to 63fd931 Mar 11, 2019

@BhaaLseN
Copy link
Member

BhaaLseN left a comment

Code seems good, untested tho.

Note to self: parent->window() cannot be null; either it is a widget on a window, or it is a window itself.

@spycrab spycrab merged commit 909e932 into dolphin-emu:master Mar 11, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@spycrab spycrab deleted the spycrab:qt_msgbox_fixes branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.