Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Save movie when closing emulation #7884

Merged
merged 2 commits into from Mar 16, 2019

Conversation

2 participants
@JosJuice
Copy link
Contributor

JosJuice commented Mar 13, 2019

Missing feature from DolphinWX.

DolphinQt: Save movie when closing emulation
Missing feature from DolphinWX.

@JosJuice JosJuice force-pushed the JosJuice:save-movie-on-exit branch from 66faff6 to 185b1cf Mar 13, 2019

@BhaaLseN
Copy link
Member

BhaaLseN left a comment

Code seems fine; I guess we'll just have to wait for feedback if someone does want the old behavior. Untested btw.

@JosJuice JosJuice merged commit 08ca9ec into dolphin-emu:master Mar 16, 2019

9 of 10 checks passed

pr-osx-x64 Build failed on builder pr-osx-x64
Details
default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@JosJuice JosJuice deleted the JosJuice:save-movie-on-exit branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.