Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerPC: Thread state through CR0 helper #7886

Open
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@CrystalGamma
Copy link

CrystalGamma commented Mar 13, 2019

No description provided.

@@ -9,13 +9,13 @@
#include "Common/Logging/Log.h"
#include "Core/PowerPC/PowerPC.h"

void Interpreter::Helper_UpdateCR0(u32 value)
static void Helper_UpdateCR0(PowerPC::PowerPCState* ppcs, u32 value)

This comment has been minimized.

@lioncash

lioncash Mar 13, 2019

Member

This can just be made a member function of PowerPCState

This comment has been minimized.

@Tilka

Tilka Mar 15, 2019

Member

I think the idea was to keep PowerPCState separate from interpreter-specific code. (Is it interpreter-specific?)

This comment has been minimized.

@CrystalGamma

CrystalGamma Mar 15, 2019

Author

We should probably decide on a policy for adding methods to PowerPCState, since some other PRs have similar candidates (e. g. UpdateCR1 and SetSR in #7889).

This comment has been minimized.

@lioncash

lioncash Mar 16, 2019

Member

It's not really interpreter-specific, since it doesn't actually operate on any interpreter state, but operates on the PowerPC state exclusively

This comment has been minimized.

@CrystalGamma

CrystalGamma Mar 16, 2019

Author

… not that there's any "interpreter state" left after #7896, except for m_end_block, which I intend to convert into a return value when I change the interpreter routine signature to include a pointer/reference to something that contains PowerPCState.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.