Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UICommon/ResourcePack: Mark ResourcePack's operator== as const #7888

Merged
merged 2 commits into from Mar 13, 2019

Conversation

4 participants
@lioncash
Copy link
Member

lioncash commented Mar 13, 2019

This doesn't modify instance state, so it can be marked as a const member function. While we're at it, also provide the inequality operator for logical symmetry.

lioncash added some commits Mar 13, 2019

UICommon/ResourcePack: Provide inequality operator to complement equa…
…lity operator

Provides symmetrical behavior with the equality operator.

@JosJuice JosJuice merged commit bc9e9ca into dolphin-emu:master Mar 13, 2019

9 checks passed

default Very basic checks passed, handed off to Buildbot.
Details
lint Build succeeded on builder lint
Details
pr-android Build succeeded on builder pr-android
Details
pr-deb-dbg-x64 Build succeeded on builder pr-deb-dbg-x64
Details
pr-deb-x64 Build succeeded on builder pr-deb-x64
Details
pr-freebsd-x64 Build succeeded on builder pr-freebsd-x64
Details
pr-ubu-x64 Build succeeded on builder pr-ubu-x64
Details
pr-win-dbg-x64 Build succeeded on builder pr-win-dbg-x64
Details
pr-win-x64 Build succeeded on builder pr-win-x64
Details

@lioncash lioncash deleted the lioncash:const branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.