Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for black screen on Linux upon starting a game #789

Merged
merged 1 commit into from Aug 21, 2014
Merged

Fix for black screen on Linux upon starting a game #789

merged 1 commit into from Aug 21, 2014

Conversation

archshift
Copy link
Contributor

Waiting on @magcius's branch to be merged.

return false;
}

s_backbuffer_width = attribs.width;

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@Matoking
Copy link

This fixes the issue of the screen being black (or gray as of commit 7b6b9b0, most likely due to the renderFrame being on top of a wxPanel) when emulation is started on Linux. The issue could also be fixed by toggling the fullscreen off, after which it would display correctly even if fullscreen was enabled again.

The aspect ratio is retained and the image scales correctly when resizing the window both when Render to Main Window is enabled and when it's not enabled.

Even if there were some minor issues with this commit, at the moment it seems to be far better than having a blank screen when the game is launched.

@archshift archshift mentioned this pull request Aug 16, 2014
lioncash referenced this pull request Aug 17, 2014
Also remove x, y, width and height from the GLInterface, since it's only
used in GLX, which no longer uses them
@lioncash
Copy link
Member

This needs to be rebased.

@archshift
Copy link
Contributor Author

There you go. I've tested this and it fixes the problem on both WX Dolphin and NoGUI Dolphin.

if (!XGetWindowAttributes(dpy, parent, &attribs))
{
ERROR_LOG(VIDEO, "Window attribute retrieval failed");
return 0;

This comment was marked as off-topic.

lioncash added a commit that referenced this pull request Aug 21, 2014
Fix for black screen on Linux upon starting a game
@lioncash lioncash merged commit 48f52b9 into dolphin-emu:master Aug 21, 2014
@archshift archshift deleted the linuxvideo branch August 21, 2014 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants