PowerPC: Move lwarx/stwcxd. reservation into PowerPCState #7896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrystalGamma
force-pushed
the
pr-reserve
branch
2 times, most recently
from
38b529f
to
2b5be99
Compare
CrystalGamma
force-pushed
the
pr-reserve
branch
from
2b5be99
to
bf1cb29
Compare
CrystalGamma
force-pushed
the
pr-reserve
branch
2 times, most recently
from
8c97ee5
to
046c50a
Compare
leoetlino
reviewed
Jul 17, 2021
Source/Core/Core/PowerPC/PowerPC.cpp
Outdated
| @@ -125,6 +125,17 @@ void DoState(PointerWrap& p) | |||
| p.Do(ppcState.pagetable_base); | |||
| p.Do(ppcState.pagetable_hashmask); | |||
|
|
|||
| if (version >= 133) | |||
There was a problem hiding this comment.
I'm not sure having backwards compatibility for savestates is worth the increased maintenance burden.
There was a problem hiding this comment.
I can take the commit back out if you want. Anyone else who might have an opinion on this?
leoetlino
requested changes
Jul 21, 2021
leoetlino
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.